[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2023-01-06 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063886879 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2023-01-06 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063879030 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2023-01-06 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r1063869321 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -287,12 +291,16 @@ public RecordAppendResult append(String topi

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2022-08-24 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r954487697 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -273,26 +273,29 @@ public RecordAppendResult append(String topic

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2022-08-16 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r947453899 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -273,26 +273,29 @@ public RecordAppendResult append(String topic

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2022-08-05 Thread GitBox
artemlivshits commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r938985421 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -273,26 +273,29 @@ public RecordAppendResult append(String topic