[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r960902453 ## core/src/main/scala/kafka/server/metadata/MetadataSnapshotter.scala: ## @@ -31,5 +32,5 @@ trait MetadataSnapshotter { * * @return True

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r960901993 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala: ## @@ -59,11 +60,11 @@ class BrokerMetadataSnapshotter( val writer =

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r960901730 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -119,16 +120,29 @@ class BrokerMetadataListener( }

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r951002747 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1914,6 +1915,7 @@ public CompletableFuture> createPartitions( }); }

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r943241275 ## raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java: ## @@ -107,6 +107,8 @@ public synchronized void handleCommit(BatchReader reader) { }

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r943240735 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala: ## @@ -59,11 +60,19 @@ class BrokerMetadataSnapshotter( val writer =

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r933081305 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -119,16 +119,24 @@ class BrokerMetadataListener( }

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r928623470 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -119,16 +119,24 @@ class BrokerMetadataListener( }

[GitHub] [kafka] ashmeet13 commented on a diff in pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on code in PR #12414: URL: https://github.com/apache/kafka/pull/12414#discussion_r924807677 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -89,6 +89,12 @@ class BrokerMetadataListener( */ private var