[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r469422110 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,26 +181,42 @@ void openDB(final ProcessorContext

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r469095757 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,26 +181,42 @@ void openDB(final ProcessorContext

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-11 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r468802841 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -204,17 +204,17 @@ private void maybeSetUpStatistics(f

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-11 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r468796333 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,26 +181,42 @@ void openDB(final ProcessorContext

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-07-31 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r463617899 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,23 +181,39 @@ void openDB(final ProcessorContext

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-07-31 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r463578816 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java ## @@ -227,7 +228,8 @@ public MockProcessorCont