[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-15 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r897887371 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,422 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-15 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r897835619 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-15 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r897818350 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-15 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r897789473 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895651419 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895564024 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r89390 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895542975 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-09 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r893379903 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-09 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r893372025 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-09 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r893370030 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-09 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r893161440 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadataTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-01 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r886734791 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -479,6 +485,26 @@ public void restore(final Map tasks) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-01 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r886732983 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -479,6 +485,26 @@ public void restore(final Map tasks) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-01 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r886667358 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-05-24 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880526257 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -783,6 +822,28 @@ public void shouldThrowOnCleanupWhileRunning() throws

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-05-18 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r875647755 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1662,6 +1663,51 @@ public T store(final StoreQueryParameters storeQueryParameters) {