[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-1006930874 ping @kowshik @junrao @hachikuji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-999311076 @kowshik @junrao @hachikuji I have addressed the review comments and please take a look. thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-975995094 @junrao I accidentally changed the `core/src/main/scala/kafka/utils/Logging.scala` file which made it not compiling. Fixed the compilation issue now. -- This is an automated

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-972062540 @kowshik @junrao I fixed the issues. Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648 @junrao I think this should solve the issue. Please take a look cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648 @junrao I think this should solve the issue. Please take a look cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-961961648 @junrao I think this should solve the issue. Please take a look cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-953183374 The change failed recovery point check at

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-953099762 @junrao @kowshik I addressed the above comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-948707270 @kowshik I will find some time to work on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-933622186 While I am working on the test, I have a question: The `log.flush()` function is also called at

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-928310964 ping @junrao @ijuma for code review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-928310964 ping @junrao @ijuma for code review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-926250962 Failed tests are irrelevant and passed on my local run. ``` Build / JDK 8 and Scala 2.12 /

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-925468033 @kowshik Thanks for the code review. Updated your email in the PR description as well as in the commit message. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-924981747 Updated the Test section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-923364265 cc @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific