chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r533093802
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -1271,27 +1270,48 @@ public void
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r533093616
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r533092986
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -314,27 +315,23 @@ public KafkaProducer(Properties
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r533092957
##
File path:
clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java
##
@@ -79,25 +80,52 @@ public void
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r533079695
##
File path:
clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java
##
@@ -79,25 +80,52 @@ public void
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r528169002
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527470855
##
File path:
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##
@@ -159,24 +159,25 @@ private static ChannelBuilder
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527469991
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -366,8 +379,9 @@ public void testMetadataFetch()
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527352682
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2588,6 +2589,21 @@ public void
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527352078
##
File path:
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##
@@ -79,14 +79,29 @@ public SslFactory(Mode mode,
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527347652
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r520293926
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r520237060
##
File path:
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##
@@ -159,24 +159,25 @@ private static ChannelBuilder
chia7712 commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r446547308
##
File path:
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##
@@ -159,24 +159,23 @@ private static ChannelBuilder
14 matches
Mail list logo