[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500361487 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,174 +996,7 @@ object GroupMetadataManager { val

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500352497 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1257,60 +1059,31 @@ object GroupMetadataManager {

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-04 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r499348032 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1211,37 +1033,30 @@ object GroupMetadataManager { def

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-02 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r498957874 ## File path: core/src/main/scala/kafka/common/OffsetAndMetadata.scala ## @@ -45,8 +45,4 @@ object OffsetAndMetadata { def apply(offset: Long,

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-02 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r498936138 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -998,173 +997,13 @@ object GroupMetadataManager { val

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-30 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r497391530 ## File path: core/src/main/resources/common/message/OffsetCommitRequest.json ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-30 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r497391110 ## File path: core/src/main/resources/common/message/GroupMetadataResponse.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495966600 ## File path: core/src/main/resources/common/message/GroupMetadataResponse.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495940420 ## File path: core/src/main/resources/common/message/OffsetCommitRequest.json ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495940420 ## File path: core/src/main/resources/common/message/OffsetCommitRequest.json ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495932581 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,173 +996,45 @@ object GroupMetadataManager { val

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495919910 ## File path: core/src/main/resources/common/message/OffsetCommitResponse.json ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r495918349 ## File path: core/src/main/resources/common/message/GroupMetadataRequest.json ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696066 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696416 ## File path: core/src/main/resources/common/message/GroupMetadataValue.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696066 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val