[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r587216418 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,105 @@ public int sessionId() { * @param

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585695430 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,79 +754,85 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585681834 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,79 +754,85 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585674420 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,98 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585235586 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,92 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585229860 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,92 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585226663 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +126,92 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585224829 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,79 +754,84 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585224204 ## File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala ## @@ -534,15 +588,21 @@ class FetchSessionTest { Optional.empty()))

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585221282 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -1144,8 +1143,14 @@ class AbstractFetcherThreadTest {

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r585219789 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -416,9 +412,8 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584225973 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -304,58 +115,12 @@ public int sessionId() { public Map

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584224981 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584224855 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584224750 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584224693 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584222449 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetchsession/FetchSessionBenchmark.java ## @@ -70,24 +70,25 @@ public void setUp() {

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584222409 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/FetchResponseBenchmark.java ## @@ -78,19 +78,25 @@ public void setup() { f

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584222186 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetcher/ReplicaFetcherThreadBenchmark.java ## @@ -174,8 +173,14 @@ public int sizeInBytes(

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584221983 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -734,7 +730,7 @@ abstract class AbstractFetcherThread(name: String, O

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584221805 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -340,7 +336,8 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584221661 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +123,70 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584221036 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -365,17 +123,70 @@ public int sessionId() { * @param p

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584165033 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index l

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r584148817 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -57,238 +56,39 @@ * the fetch offset after the index l

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r581131032 ## File path: clients/src/main/resources/common/message/FetchResponse.json ## @@ -53,9 +53,9 @@ "about": "The response topics.", "fields": [

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r581088681 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -290,7 +291,7 @@ public void onSuccess(ClientResponse r

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552403231 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -304,58 +115,12 @@ public int sessionId() { public Map

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552126351 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r552053003 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r551441782 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r546203915 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -777,12 +775,12 @@ class KafkaApis(val requestChannel: RequestChannel, } d