[GitHub] [kafka] chia7712 commented on a change in pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9960: URL: https://github.com/apache/kafka/pull/9960#discussion_r563481973 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java ## @@ -188,9 +185,7 @@ public KafkaPr

[GitHub] [kafka] chia7712 commented on a change in pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9960: URL: https://github.com/apache/kafka/pull/9960#discussion_r563560802 ## File path: clients/src/main/resources/common/message/README.md ## @@ -157,9 +157,6 @@ meaning of the request, such as a "validateOnly" boolean, should

[GitHub] [kafka] chia7712 commented on a change in pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-24 Thread GitBox
chia7712 commented on a change in pull request #9960: URL: https://github.com/apache/kafka/pull/9960#discussion_r563481973 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java ## @@ -188,9 +185,7 @@ public KafkaPr