[GitHub] [kafka] chia7712 commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

2023-03-01 Thread via GitHub
chia7712 commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1450145297 @divijvaidya thanks for great feedback! > we have also have to ensure that deadlock doesn't occur when trying to acquire SocketServer lock and Processors lock. that is inte

[GitHub] [kafka] chia7712 commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

2023-02-28 Thread via GitHub
chia7712 commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1448290193 > Consider the following scenario which will go wrong with the changes in this PR: @divijvaidya thanks for nice explanation. You are right. I will adopt the solution#1 - reduce t

[GitHub] [kafka] chia7712 commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

2023-02-24 Thread via GitHub
chia7712 commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1443786837 @divijvaidya thanks for feedback! > However, the processors are stored in an ArrayBuffer which is mutable. pardon me. the mutable ArrayBuffer won't be modified after it is