[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-27 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-717116228 ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta ``` it is traced by https://issues.apache.org/jira/browse/KAFKA-

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-26 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-717023388 add a trivial change to trigger QA again This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-26 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-717022055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-25 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-716126171 All green :) @ijuma @hachikuji Could you take a look? This is an automated message from the Apache Git Ser

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-10-04 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-703261725 ``` Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` unrelated error. rebase

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-23 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-697223860 ``` Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` It is flaky on my local so it should b

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-22 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-696523232 ``` Build / JDK 15 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] Build / JDK 8 / kafka.api.ConsumerBounceTest

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-21 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-696523232 ``` Build / JDK 15 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] Build / JDK 8 / kafka.api.ConsumerBounceTest

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-12 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-12 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-10 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676 ``` Build / JDK 11 / kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition ``` pass on my local ``` Build / JDK 15 / org.apache.kafka.clien

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-09 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-689963179 @ijuma I have attached test result and ```NonLocalReturnException``` is gone. Please take a look. This is an aut

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-24 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-679805254 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-21 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561 ```testMetadataRetries``` is traced by #9091 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-18 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-67533 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-14 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-673942147 only ```shouldUpgradeFromEosAlphaToEosBeta``` fails. retest this please This is an automated message from the Apa

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-12 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-673212958 ```org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true]``` failed. I test it on my local and it pass. retest this please

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-12 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-672957838 > Yeah, I would fix all the cases in this file at once if possible. sure This is an automated message from