[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-29 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-700904592 @hachikuji Thanks for reviews and update! This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-699440096 @hachikuji the ```docs/upgrade.html``` is updated :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-699025599 > To clarify, were you going to mention this in docs/upgrade.html? will copy that This is an automated mes

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-698083970 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` it is flaky on trunk branch also so it is unr

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-23 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-698083970 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` it is flaky on trunk branch also so it is unr

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-22 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696528358 > So the previous behavior would have caused the updated configuration to be persisted, but it wouldn't take effect until the broker was restarted. Is that right? You do g

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696528358 > So the previous behavior would have caused the updated configuration to be persisted, but it wouldn't take effect until the broker was restarted. Is that right? You do g

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696082528 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` only jdk 11 get failed test. It is unrela

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696082528 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` only jdk 11 get failed test. It is unrela

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-18 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-695164715 > I see the failure consistently running this branch locally my bad. I looped tests with incorrect branch :( I have fixed the failed test. @dongjinleekr @hachikuji pl

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-18 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-694954746 > Can you take a look at DynamicConnectionsQuotaTest? Looks like this patch is causing it to fail. The error message should be unrelate to this patch. Also, I loop it 5 tim

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-14 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-692407421 the failure tests are unrelated to this patch. rebase :) @hachikuji @rajinisivaram Could you take a look? This issue was introduced by https://github.com/apache/kafk