chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728999480
> Can you check that the @hachikuji's perf test doesn't result in
significantly increased latency?
I don't observer significantly increased latency on my local. The env is
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728812062
@hachikuji @ijuma It seems to me the root cause of regression is caused by
the conversion between old data struct and auto-generated protocol. As we all
care for performance, I
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728664200
@hachikuji @ijuma Thanks for all feedback. I'm going to do more tests :)
This is an automated message from the
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-727856785
@hachikuji @ijuma @lbradstreet @dajac I have updated the perf result. The
regression is reduced by last commit. Please take a look.
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-727825315
The last commit borrows some improvement from #9563.
This is an automated message from the Apache Git Service.
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-725786213
@hachikuji @ijuma @lbradstreet Could you take a look? There are some
follow-ups which can get back the performance we lose here and I'd like to work
on them as soon as possible
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-723875285
> Can we summarize the regression here for a real world workload?
@ijuma I have attached benchmark result to description. I will loop more
benchmark later.
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-721487169
@lbradstreet Thanks for your response.
> is this the overall broker side regression since you need both the
construction and toStruct?
you are right and it seems
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-709709526
@hachikuji Could you please take a look?
This is an automated message from the Apache Git Service.
To respond to
