chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730960958
@tombentley Thanks for your patch!
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730516709
@tombentley thanks! I will merge this PR tomorrow if no objection :)
This is an automated message from the
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730480556
IIRC, the retest command does not work currently. Could you rebase code to
trigger QA?
This is an automated
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-730478145
@tombentley Could you trigger QA again?
This is an automated message from the Apache Git Service.
To respond to
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724592314
@tombentley Thanks for your sharing. It inspires me to think about the
possible solution. The following comment is not related to this PR. just
discussion
> That's a
chia7712 commented on pull request #9433:
URL: https://github.com/apache/kafka/pull/9433#issuecomment-724472427
Could you offer test to make sure ```None``` is included.
Personally, the implementations of ```errorCounts``` are almost same. Maybe
it should be implemented
by
