[GitHub] [kafka] chia7712 commented on pull request #9851: KAFKA-10769 Remove JoinGroupRequest#containsValidPattern as it is dup…

2021-04-01 Thread GitBox
chia7712 commented on pull request #9851: URL: https://github.com/apache/kafka/pull/9851#issuecomment-811724851 yep, please merge trunk. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9851: KAFKA-10769 Remove JoinGroupRequest#containsValidPattern as it is dup…

2021-03-30 Thread GitBox
chia7712 commented on pull request #9851: URL: https://github.com/apache/kafka/pull/9851#issuecomment-810025163 @highluck Could you merge trunk to trigger QA again? It seems our jenkins was on vacation before :) -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] chia7712 commented on pull request #9851: KAFKA-10769 Remove JoinGroupRequest#containsValidPattern as it is dup…

2021-01-09 Thread GitBox
chia7712 commented on pull request #9851: URL: https://github.com/apache/kafka/pull/9851#issuecomment-757424644 @abbccdda Could we reuse the code (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L36) to do the validation for sta

[GitHub] [kafka] chia7712 commented on pull request #9851: KAFKA-10769 Remove JoinGroupRequest#containsValidPattern as it is dup…

2021-01-09 Thread GitBox
chia7712 commented on pull request #9851: URL: https://github.com/apache/kafka/pull/9851#issuecomment-757423842 @highluck Thanks for your patch. The check of static group id (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRe