[GitHub] [kafka] chia7712 commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

chia7712 commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767406586 > But since my intention with this patch was to not change the iteration behavior, I'm hoping the PR in its existing form is acceptable. make sense to me :) -

[GitHub] [kafka] chia7712 commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

chia7712 commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767395806 @kowshik Thanks for your response. This patch is LGTM and I just want to clarify the usage of ```segmentsCopy``` The instance of ```segmentsCopy``` is ```ConcurrentSkipList

[GitHub] [kafka] chia7712 commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

chia7712 commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767317353 ```logSegments``` is thread-safe so is the copy necessary in this case? This is an automated message from the Apa