[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968209811 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4068,18 +3796,14 @@ public void shouldConvertStandbyTaskToActiveTask()

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968208668 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2180,29 +2035,16 @@ public void shouldCommitAllActiveTasksThatNeedComm

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968207227 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -271,11 +265,13 @@ public void shouldClassifyExistingTasksWithStateUpdat

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968206590 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() { t

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968206590 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4091,21 +3815,20 @@ public void shouldListNotPausedTasks() { t

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968204971 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1300,28 +1229,16 @@ public void shouldCloseActiveTasksWhenHandlingLost

[GitHub] [kafka] clolov commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-12 Thread GitBox
clolov commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r968200658 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -325,25 +318,21 @@ public void shouldHandleRemovedTasksToRecycleFromSta