[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1197688699 Well somewhere between reading the comments, having a discussion and typing my response I confused the options. I don't see why allowing JUnit 4 tests to run alongside JUnit 5 tests

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195674893 Divij and I also prefer option 3 because of the same reasons posted by Bruno. So the next steps on our side are: 1) Address comments on https://github.com/apache/kafka/pull/12441 which

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195428834 Hello @cadonna! I spoke with Divij offline and we found a way to run both JUnit 4 and JUnit 5 tests while the migration is going on. The pull request which should enable this is

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1193806664 So then would you like me to coalesce https://github.com/apache/kafka/pull/12301 and https://github.com/apache/kafka/pull/12302 into one, add all remaining tests, make the changes to

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1192206399 I don't know, but I can have a look in the upcoming days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1191436663 Hey @cadonna, I rebased on top of trunk. Do let me know if there is something else you would like me to address :) -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1180174715 Politely bumping the review @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1157514249 @cadonna @ijuma @divijvaidya @Kvicii I hope the latest commits address all of the suggestions above :) -- This is an automated message from the Apache Git Service. To respond to the