[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-22 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1323460811 Yay  , thank you for your help in reviewing, approving and merging this @cadonna! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-02 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1299981863 Hello @cadonna. Apologies, I am back on having bandwidth to move this (and the rest of the pull requests) to a conclusion. I will post an update later today. -- This is an automated

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-09 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1241764136 Heya @cadonna and thank you very much for the review! I will address your comments over the next few days. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-15 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1215575745 Hey @dplavcic, thank you for the comments. I will aim to provide an answer in the next couple of days! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-12 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1212874952 I am aware checkstyle is complaining about some indentation which I will fix later throughout the day. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] clolov commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-11 Thread GitBox
clolov commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1212166713 Tagging @mdedetrich @cadonna @ijuma for visibility and reviews :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use