clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1311662067
@cadonna I suspect the automatic merge from GitHub will fix things, but if
not I can rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1308588950
Hopefully the newest two commits address your comments @ableegoldman, if not
just let me know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, p
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1308324630
Thank you for the review! All of these are valid suggestions, I will aim to
get them done today.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1305605846
Hey @cadonna, Adam Retter has been very helpful in responding to my mail, so
I have updated the pull request with his suggestion. I believe this is option
2, but the reasoning behind it ma
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1301915739
@cadonna, I wrote earlier today to
https://groups.google.com/g/rocksdb/c/DWsH8Yda5gc. I will wait for a day and if
there isn't a response I will also open an issue as you suggest :)
--
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298605281
I need to check how Gradle handles dependencies, but maybe taking a direct
dependency on `zlib 1.2.12` will overwrite the version used by rocksdb?
--
This is an automated message from th
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298601942
Hello @cadonna! In my opinion 1 is a clean solution and it is probably
something we can contribute ourselves - I can try doing it in the upcoming
days. I think 2 is similar to 3 in breakin
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298495188
Hello @ableegoldman! I am tagging you since I saw you are the release
manager for 3.4.0 and this addresses
https://issues.apache.org/jira/browse/KAFKA-14324 which is listed as a blocker
f
