clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1658538656
The failures in JDK 8/Scala 2.12 have to do with formatting on code which
hasn't been touched as part of this pull request, so I believe it is safe to go
ahead.
There are 2
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1658242751
It appears that in Zookeeper 3.8.0 the Zookeeper community moved away from
log4j to logback (source: https://issues.apache.org/jira/browse/ZOOKEEPER-4427)
In the failing test cases
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655850239
Zoning in on ControllerIntegrationTest#testControllerMoveOnTopicCreation:
```
...
val event = appender.getMessages.find(e => e.getLevel == Level.INFO
&&
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655821383
At least on a first look it appears something changed/is wrong with the
loggers:
```
[2023-02-22T17:35:34.655Z] Gradle Test Run :core:unitTest > Gradle Test
Executor 136 >
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1655753598
At least the below tests have started to continuously fail. I am still
looking as to why:
```
Gradle Test Run :core:test > Gradle Test Executor 3 >
ControllerIntegrationTest >
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1641957263
Hey @forlack! Thank you for the suggestion, I have upgraded the dependency
so that tests can run.
Heya @mimaison, I have addressed your comment about adding the latest
version to
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1628903388
> I'm not familiar with these tests so please correct me if I'm not
understanding something correctly.
>
> First, the KIP states (Compatibility, Deprecation, and Migration Plan
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1604416528
I ran
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/core/upgrade_test.py#L33
and all tests passed. I have confirmed that as part of the tests we start with
an older
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1581120917
I have not, but I will aim to carry out the check in the upcoming days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1516273036
Hello @mimaison, @ijuma and @cmccabe! Since
[KIP-902](https://cwiki.apache.org/confluence/display/KAFKA/KIP-902%3A+Upgrade+Zookeeper+to+3.8.1)
has been accepted I have rebased this pull
10 matches
Mail list logo
