[GitHub] [kafka] clolov commented on pull request #13711: KAFKA-14133: Migrate StandbyTaskCreator mock in TaskManagerTest to Mockito

clolov commented on PR #13711: URL: https://github.com/apache/kafka/pull/13711#issuecomment-1592595315 Good morning! I believe that the failing checks are not connected with this change. Is it okay to merge this PR? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] clolov commented on pull request #13711: KAFKA-14133: Migrate StandbyTaskCreator mock in TaskManagerTest to Mockito

clolov commented on PR #13711: URL: https://github.com/apache/kafka/pull/13711#issuecomment-1588950243 Okay, the name has been changed and this has been rebased. I ran checkstyleTest and spotbugsTest and they are passing locally. If everything passes in the automated tests you should be abl

[GitHub] [kafka] clolov commented on pull request #13711: KAFKA-14133: Migrate StandbyTaskCreator mock in TaskManagerTest to Mockito

clolov commented on PR #13711: URL: https://github.com/apache/kafka/pull/13711#issuecomment-1578656781 Heya @cadonna, I hope I have addressed all of your comments: * Updated the PR's overview * Rebased * Comments on the code itself Interestingly enough the test `shouldInitiali

[GitHub] [kafka] clolov commented on pull request #13711: KAFKA-14133: Migrate StandbyTaskCreator mock in TaskManagerTest to Mockito

clolov commented on PR #13711: URL: https://github.com/apache/kafka/pull/13711#issuecomment-1576886607 Yup, I will address all comments today, thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t