[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-03 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r586739230 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -541,6 +575,64 @@ static void validateNewTopicNames

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-02 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r585942960 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -809,6 +824,27 @@ private QuorumController(LogContext logCon

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-02 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r585942730 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChang

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-03-02 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r585891911 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584009213 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChang

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584007497 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChang

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583965997 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583962844 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583940888 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583940677 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583903614 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void replay(PartitionChang

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583900849 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-25 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084940 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-25 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084940 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-25 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084809 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-25 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084592 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -541,6 +559,57 @@ static void validateNewTopicNames

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-25 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583077539 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582259112 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582257154 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -541,6 +559,41 @@ static void validateNewTopicNames

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582257154 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -541,6 +559,41 @@ static void validateNewTopicNames

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582256432 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582256432 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582255681 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-24 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582255514 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +198,61 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-22 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r580825461 ## File path: config/log4j.properties ## @@ -61,11 +61,11 @@ log4j.appender.authorizerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n log4j.logger.o