[GitHub] [kafka] cmccabe commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

cmccabe commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r612656387 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1007,6 +999,128 @@ int bestLeader(int[] replicas,

[GitHub] [kafka] cmccabe commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

cmccabe commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r609096892 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1007,6 +1014,112 @@ int bestLeader(int[] replicas,

[GitHub] [kafka] cmccabe commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

cmccabe commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r609098540 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -518,4 +523,89 @@ public void testDeleteTopics(

[GitHub] [kafka] cmccabe commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

cmccabe commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r609093462 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -538,4 +542,57 @@ class ControllerApis(val requestChannel: RequestChannel,