[GitHub] [kafka] cmccabe commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

2021-07-01 Thread GitBox
cmccabe commented on a change in pull request #10946: URL: https://github.com/apache/kafka/pull/10946#discussion_r662614408 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -495,6 +506,10 @@ public int sizeInBytes() {

[GitHub] [kafka] cmccabe commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

2021-07-01 Thread GitBox
cmccabe commented on a change in pull request #10946: URL: https://github.com/apache/kafka/pull/10946#discussion_r662602197 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -207,6 +208,12 @@ private void completeCurrentBatch() {

[GitHub] [kafka] cmccabe commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

2021-07-01 Thread GitBox
cmccabe commented on a change in pull request #10946: URL: https://github.com/apache/kafka/pull/10946#discussion_r662601954 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -106,7 +108,10 @@ public synchronized void handleCommit(BatchReader

[GitHub] [kafka] cmccabe commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

2021-07-01 Thread GitBox
cmccabe commented on a change in pull request #10946: URL: https://github.com/apache/kafka/pull/10946#discussion_r662600721 ## File path: raft/src/main/java/org/apache/kafka/raft/Batch.java ## @@ -99,38 +116,68 @@ public boolean equals(Object o) { Batch batch =

[GitHub] [kafka] cmccabe commented on a change in pull request #10946: KAFKA-12997: Expose the append time for batches from raft

2021-07-01 Thread GitBox
cmccabe commented on a change in pull request #10946: URL: https://github.com/apache/kafka/pull/10946#discussion_r662599796 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -198,7 +207,12 @@ synchronized void