[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndE

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndE

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716954 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -651,20 +661,21 @@ public void handleCommit(BatchReader rea

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716671 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -178,14 +178,18 @@ public Snapshot getSnapshot(long epoch) {

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndE