[GitHub] [kafka] cmccabe commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-02-02 Thread GitBox
cmccabe commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r797873026 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -1506,6 +1508,46 @@ public void testNullTopicName() {

[GitHub] [kafka] cmccabe commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-01-20 Thread GitBox
cmccabe commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r788922915 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -1506,6 +1508,56 @@ public void testNullTopicName() {

[GitHub] [kafka] cmccabe commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-01-20 Thread GitBox
cmccabe commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r788921625 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerInterceptors.java ## @@ -123,6 +122,10 @@ public void onSendError

[GitHub] [kafka] cmccabe commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-01-20 Thread GitBox
cmccabe commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r788919892 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/Callback.java ## @@ -25,10 +25,10 @@ /** * A callback method the user can