[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading [WIP]

2022-05-04 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r865499094 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1864,6 +1780,18 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics: Metrics) extend

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading [WIP]

2022-05-04 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r865496509 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -104,184 +103,141 @@ class SocketServer(val config: KafkaConfig, private[this] val nextProcessorId:

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading [WIP]

2022-05-04 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r865495994 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -104,184 +103,141 @@ class SocketServer(val config: KafkaConfig, private[this] val nextProcessorId:

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading [WIP]

2022-05-04 Thread GitBox
cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r865495566 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -906,12 +906,35 @@ private void appendRaftEvent(String name, Runnable runnable) {