[GitHub] [kafka] cmccabe commented on a diff in pull request #12177: KAKFA-13410 Generate snapshot prior to metadata.version upgrade

2022-05-18 Thread GitBox
cmccabe commented on code in PR #12177: URL: https://github.com/apache/kafka/pull/12177#discussion_r876326240 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1735,17 +1742,38 @@ public CompletableFuture updateFeatures( ControllerRequ

[GitHub] [kafka] cmccabe commented on a diff in pull request #12177: KAKFA-13410 Generate snapshot prior to metadata.version upgrade

2022-05-18 Thread GitBox
cmccabe commented on code in PR #12177: URL: https://github.com/apache/kafka/pull/12177#discussion_r876325079 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1735,17 +1742,38 @@ public CompletableFuture updateFeatures( ControllerRequ