[GitHub] [kafka] cmccabe commented on a diff in pull request #12946: KAFKA-14427 ZK client support for migrations

2022-12-06 Thread GitBox
cmccabe commented on code in PR #12946: URL: https://github.com/apache/kafka/pull/12946#discussion_r1041288418 ## metadata/src/main/java/org/apache/kafka/metadata/migration/ZkMigrationLeadershipState.java: ## @@ -100,26 +106,30 @@ public boolean zkMigrationComplete() { @Ove

[GitHub] [kafka] cmccabe commented on a diff in pull request #12946: KAFKA-14427 ZK client support for migrations

2022-12-06 Thread GitBox
cmccabe commented on code in PR #12946: URL: https://github.com/apache/kafka/pull/12946#discussion_r1041287139 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -54,6 +54,19 @@ import org.apache.kafka.common.utils.Sanitizer import scala.collection.{Map, mutable, _