[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1092446989 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -573,7 +591,20 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, private val

[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1092445406 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -585,23 +616,35 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, private var

[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1091087602 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis()

[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1091061226 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis()