[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1319165974 ## clients/src/main/resources/common/message/ControllerRegistrationRequest.json: ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316395025 ## clients/src/main/java/org/apache/kafka/common/requests/ControllerRegistrationRequest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316393751 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316393088 ## clients/src/main/resources/common/message/ControllerRegistrationRequest.json: ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1313371146 ## metadata/src/test/java/org/apache/kafka/image/publisher/ControllerRegistrationsPublisherTest.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1313363156 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312388001 ## metadata/src/main/java/org/apache/kafka/controller/ClusterSupportDescriber.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312381991 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -234,9 +247,64 @@ private ApiError updateFeature( } } +

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312379433 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312376398 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3510,43 +3510,34 @@ class KafkaApis(val requestChannel: RequestChannel, } def

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312373575 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312372539 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312372436 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312369046 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312369046 ## core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312367762 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -1005,4 +1023,20 @@ class ControllerApis(val requestChannel: RequestChannel, } } } +

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312363063 ## core/src/test/scala/unit/kafka/server/ControllerRegistrationManagerTest.scala: ## @@ -0,0 +1,272 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312362682 ## core/src/test/resources/log4j.properties: ## @@ -12,14 +12,14 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312362333 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def