[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343631 There are a lot of whitespace-only changes in this PR that are kind of confusing. Can you please do these in a separate PR or just drop them?

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343269 Same issue with `kafka-reassign-partitions.sh`. It also needs to be converted to use `--bootstrap-server`. This is an

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618342661 It looks like the places where we invoke `kafka-configs.sh` still need to be converted over to use `--bootstrap-server`

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335 > For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet. We need to keep using --zookeeper in the SCRAM case since we don't