[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

2021-10-26 Thread GitBox
cmccabe commented on pull request #11339: URL: https://github.com/apache/kafka/pull/11339#issuecomment-952318773 I followed https://github.com/apache/kafka/pull/11437 to fix up the path that we're using. These shouldn't actually be in the config directory (because they're not configs) --

[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

2021-10-26 Thread GitBox
cmccabe commented on pull request #11339: URL: https://github.com/apache/kafka/pull/11339#issuecomment-952292489 I re-ran SaslPlainSslEndToEndAuthorizationTest and LeaderElectionCommandTest locally and they both passed. These tests are known to be flaky and the failure is not caused by thi

[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

2021-10-26 Thread GitBox
cmccabe commented on pull request #11339: URL: https://github.com/apache/kafka/pull/11339#issuecomment-952276357 @dengziming : thanks for this! I'm sorry that I've been so slow to review things lately... too much work piled up. I think it looks good. I especially liked that you added `Meta