[GitHub] [kafka] cmccabe commented on pull request #11386: MINOR: Fix highest offset when loading KRaft metadata snapshots

2021-10-13 Thread GitBox
cmccabe commented on pull request #11386: URL: https://github.com/apache/kafka/pull/11386#issuecomment-941788779 Test failures look like flakes. Committing now. Thanks, @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] cmccabe commented on pull request #11386: MINOR: Fix highest offset when loading KRaft metadata snapshots

2021-10-12 Thread GitBox
cmccabe commented on pull request #11386: URL: https://github.com/apache/kafka/pull/11386#issuecomment-941788779 Test failures look like flakes. Committing now. Thanks, @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] cmccabe commented on pull request #11386: MINOR: Fix highest offset when loading KRaft metadata snapshots

2021-10-11 Thread GitBox
cmccabe commented on pull request #11386: URL: https://github.com/apache/kafka/pull/11386#issuecomment-940558999 > When loading a snapshot the broker BrokerMetadataListener was using the batch's append time, offset and epoch. These are not the same as the append time, offset and epoch from