[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag

2020-09-14 Thread GitBox
cmccabe commented on pull request #9274: URL: https://github.com/apache/kafka/pull/9274#issuecomment-692361175 LGTM. Thanks, @rondagostino This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag

2020-09-10 Thread GitBox
cmccabe commented on pull request #9274: URL: https://github.com/apache/kafka/pull/9274#issuecomment-690623624 Looks good. LGTM pending a system test run This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag

2020-09-09 Thread GitBox
cmccabe commented on pull request #9274: URL: https://github.com/apache/kafka/pull/9274#issuecomment-689824902 Thanks, @rondagostino . Is there any way to avoid moving the acls stuff out of `kafka_acls.py`? It seems nice to have some separation rather than having everything in