[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-06 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664634309 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-06 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663713956 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-05 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663961829 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -338,16 +338,15 @@ class LogSegment private[log] (val log: FileRecords, txnIndex.res

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-05 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663877163 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,21 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-05 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663713956 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

2021-07-02 Thread GitBox
dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r662991037 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volatile for