[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465997624 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465997810 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465968369 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889824 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889447 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889286 ## File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala ## @@ -156,6 +174,24 @@ class ControllerMutationQuotaManager(private val c

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r46517 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465886919 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040813 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -223,8 +229,14 @@ public void checkQuotas(long timeMs) {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040672 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038614 ## File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala ## @@ -131,6 +133,16 @@ class PermissiveControllerMutationQuota(private va

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038411 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda