[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r542308308 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -123,9 +131,9 @@ object RequestChannel extends Logging { } } -def

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r540798413 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -121,9 +122,16 @@ object RequestChannel extends Logging { } } -de

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r526258381 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r521273910 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -375,13 +385,36 @@ private void generateVariableLengthTarget

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r520340843 ## File path: clients/src/test/java/org/apache/kafka/common/message/SimpleExampleMessageTest.java ## @@ -394,7 +394,7 @@ private void testRoundTrip(SimpleExa

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518387030 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518384421 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518187681 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -346,6 +346,10 @@ public ProduceResponse getErrorResponse(int

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518187139 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void generateVariableLengthTargetTo

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r517317354 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under