[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-09 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r539138004 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -223,8 +279,34 @@ class ClientQuotasRequestTest extends BaseRequestTes

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-08 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r538477244 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,13 +885,20 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537615920 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,51 @@ class AdminManager(val config: KafkaConfig, !name.isDefine

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-07 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r537615504 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536134783 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535388027 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig, !name.isDefine

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-03 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r535387504 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -56,11 +56,12 @@ import scala.collection._ * --entity-type

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-02 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r534287486 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,49 @@ class AdminManager(val config: KafkaConfig, !name.isDefine