[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-29 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r861509139 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1554,9 +1570,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Completely delete

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-28 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r860897319 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-26 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r858306274 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-25 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r858031776 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-19 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r852680173 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2703,6 +2711,26 @@ class ReplicaManagerTest { assertEquals(HostedPartition.None,

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-13 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r849824338 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def