dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r861509139
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1554,9 +1570,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Completely delete
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r860897319
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Rename the directory
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r858306274
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Rename the directory
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r858031776
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Rename the directory
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r852680173
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2703,6 +2711,26 @@ class ReplicaManagerTest {
assertEquals(HostedPartition.None,
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r849824338
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2615,7 +2615,10 @@ class ReplicaManagerTest {
@Test
def