[GitHub] [kafka] dajac commented on a diff in pull request #12339: MINOR: set UNKNOWN_MEMBER_ID explicitly when deleting group instance id

[GitBox]

dajac commented on code in PR #12339:
URL: https://github.com/apache/kafka/pull/12339#discussion_r906064565


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -3742,7 +3743,8 @@ private List<MemberIdentity> getMembersFromGroup(String 
groupId, String reason)
             MemberIdentity memberIdentity = new 
MemberIdentity().setReason(reason);
 
             if (member.groupInstanceId().isPresent()) {
-                
memberIdentity.setGroupInstanceId(member.groupInstanceId().get());
+                
memberIdentity.setGroupInstanceId(member.groupInstanceId().get())
+                        .setMemberId(JoinGroupRequest.UNKNOWN_MEMBER_ID);

Review Comment:
   Is it really better? I am not convinced because `UNKNOWN_MEMBER_ID` is the 
default value anyway. If we follow this train of thoughts, why don't we add 
`setGroupInstanceId(null)` to the else branch as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org