[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r917912085 ## clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java: ## @@ -70,6 +70,21 @@ public static void validateGroupInstanceId(String id) { });

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r917780526 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1432,4 +1432,17 @@ public static String[] enumOptions(Class> enumClass) { .toArr

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916683217 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -1164,6 +1168,34 @@ public void testHandleNormalLeaveGroupResponse

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916672037 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -1164,6 +1168,34 @@ public void testHandleNormalLeaveGroupResponse

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916573678 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1112,9 +1121,10 @@ public synchronized RequestFuture maybeLeaveGroup

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916162985 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1050,10 +1051,18 @@ public synchronized void requestRejoin(final Stri

[GitHub] [kafka] dajac commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

dajac commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916166251 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1112,9 +1121,10 @@ public synchronized RequestFuture maybeLeaveGroup