[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-27 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1178764451 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,57 @@ private boolean allSubscriptionsEqual(Set allT

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177783905 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -137,7 +136,7 @@ private boolean allSubscriptionsEqual(Set allTopi

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-19 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171774551 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncResponse,

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-18 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1169901603 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncResponse,

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-17 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1168638509 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncResponse,