[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218957638 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218956441 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218576567 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218517345 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218516113 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218516577 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerializerTest.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218515694 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218514447 ## core/src/test/scala/unit/kafka/coordinator/group/CoordinatorPartitionWriterTest.scala: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218512680 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1218511238 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1217632767 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -666,7 +667,8 @@ class ReplicaManager(val config: KafkaConfig, recordConversionStatsC

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1217620168 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java: ## @@ -131,6 +131,7 @@ public Map errorCounts() { public static final class Partition

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-05 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1217619263 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-02 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1214114184 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig, } /** - * Append the messages

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-02 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1214113530 ## core/src/main/scala/kafka/coordinator/group/PartitionWriterImpl.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-02 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1214109717 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213267178 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig, } /** - * Append the messages

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213274631 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213273088 ## core/src/test/scala/unit/kafka/coordinator/group/PartitionWriterImplTest.scala: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213271843 ## core/src/test/scala/unit/kafka/coordinator/group/PartitionWriterImplTest.scala: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213268934 ## core/src/main/scala/kafka/coordinator/group/PartitionWriterImpl.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] dajac commented on a diff in pull request #13675: KAFKA-14462; [14/N] Add PartitionWriter

2023-06-01 Thread via GitHub
dajac commented on code in PR #13675: URL: https://github.com/apache/kafka/pull/13675#discussion_r1213267178 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig, } /** - * Append the messages