[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1260813174 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3057,6 +3057,56 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255784243 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255783931 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255779604 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -118,6 +118,11 @@ protected void pollOnce(long maxTimeoutMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255778900 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -118,6 +118,11 @@ protected void pollOnce(long maxTimeoutMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255775822 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -793,19 +793,18 @@ private void failBatch( Function recordExceptions,

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1223961441 ## core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: ## @@ -3273,17 +3272,35 @@ class PartitionTest extends AbstractPartitionTest { baseOffset = 0L,

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1222426539 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -980,6 +1006,25 @@ class UnifiedLog(@volatile var logStartOffset: Long, if (duplicateBatch.isPresent)

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221998443 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221060938 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1219799829 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,9 +579,30 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe