[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263354270 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263349060 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263281176 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263068420 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263060866 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263059667 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262824134 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262475265 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262474854 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r126246 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262462756 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262460699 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2360,6 +2360,19 @@ public void testGroupIdsByTopics() {

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262458373 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262456201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262455254 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -175,7 +176,7 @@ object Defaults { val ConsumerGroupMinHeartbeatIntervalMs = 5000 val ConsumerGroupMaxH

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-11 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1260620995 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance

[GitHub] [kafka] dajac commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-11 Thread via GitHub
dajac commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1260620995 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance