[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1270405127 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269799340 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269737507 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269156330 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269155972 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269152813 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -386,6 +386,18 @@ public short groupMetadataValueVersion() { } }

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268008501 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268008967 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1268008079 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -386,6 +386,18 @@ public short groupMetadataValueVersion() { } }