[GitHub] [kafka] dajac commented on pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

dajac commented on pull request #10234: URL: https://github.com/apache/kafka/pull/10234#issuecomment-790384482 @chia7712 I just pushed a commit to address your comment. Could you take a look? This is an automated message fro

[GitHub] [kafka] dajac commented on pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

dajac commented on pull request #10234: URL: https://github.com/apache/kafka/pull/10234#issuecomment-789621268 @chia7712 I just pushed another small commit to fix/improve `LeaderAndIsrRequestTest#testGetErrorResponse`. It was not testing all the versions as claimed. I have also added asser

[GitHub] [kafka] dajac commented on pull request #10234: MINOR; Clean up LeaderAndIsrResponse construction in `ReplicaManager#becomeLeaderOrFollower`

dajac commented on pull request #10234: URL: https://github.com/apache/kafka/pull/10234#issuecomment-789522482 @chia7712 Thanks for the review. I just pushed a commit to address your comment. Could you take another look? Thi