dengziming commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554514560
##########
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##########
@@ -90,11 +92,13 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
* @param config The config of the topic
* @param partitionReplicaAssignment The assignments of the topic
* @param validate Boolean indicating if parameters must be validated or not
(true by default)
+ * @param usesTopicId Boolean indicating whether the topic ID will be created
*/
def createTopicWithAssignment(topic: String,
config: Properties,
partitionReplicaAssignment: Map[Int, Seq[Int]],
- validate: Boolean = true): Unit = {
+ validate: Boolean = true,
+ usesTopicId: Boolean = false): Unit = {
Review comment:
So if we use `TopicCommand` with `ZookeeperTopicService` to create a
topic, we will always not set a topicId?
##########
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##########
@@ -153,16 +157,17 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
LogConfig.validate(config)
}
- private def writeTopicPartitionAssignment(topic: String, replicaAssignment:
Map[Int, ReplicaAssignment], isUpdate: Boolean): Unit = {
+ private def writeTopicPartitionAssignment(topic: String, replicaAssignment:
Map[Int, ReplicaAssignment],
+ isUpdate: Boolean, usesTopicId:
Boolean = false): Unit = {
Review comment:
Why do you set the default value to false? I don't think we should give
it a default value since the caller can decide it by caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
